Review Request 128034: KateHighlightManger::defaultStyleCount() off by one

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128034/
-----------------------------------------------------------

(Updated May 28, 2016, 4:33 p.m.)


Status
------

This change has been marked as submitted.


Review request for Kate and KDE Frameworks.


Changes
-------

Submitted with commit 24bec2f4f596d881ec43099558d3111542616f7a by Dominik Haumann to branch master.


Repository: ktexteditor


Description
-------

The enum dsError should be included in the count, so we need to add 1.

With this patch, we are now able to also change the default style "Error" in the Default styles config page.

A possible other fix would be to add "dsCount" as last enum entry, and then just return KTextEditor::dsCount". Would that be a better solution? (and is adding an enum entry BC?)


Diffs
-----

  src/syntax/katesyntaxmanager.cpp 6d4b80e 

Diff: https://git.reviewboard.kde.org/r/128034/diff/


Testing
-------

Works, whereas prior to this patch, I was not able to change the color or any other attribute of dsError.


Thanks,

Dominik Haumann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160528/89379f01/attachment-0001.html>