Review Request 128035: KTextEditor: Fix foreground color of replaced text

Dominik Haumann dhaumann at kde.org
Sat May 28 16:31:01 UTC 2016



> On May 28, 2016, 2:27 p.m., Albert Astals Cid wrote:
> > I honestly don't think you need a review for such an obvious typo case as this.

I am doing it, since the KDE frameworks are supposed to be reviewed, and I personally don't want to be an exception "just because I know better" ;) But yes, I admit it's a trivial / obvious fix.


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128035/#review95950
-----------------------------------------------------------


On May 28, 2016, 4:30 p.m., Dominik Haumann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128035/
> -----------------------------------------------------------
> 
> (Updated May 28, 2016, 4:30 p.m.)
> 
> 
> Review request for Kate and KDE Frameworks.
> 
> 
> Bugs: 363441
>     https://bugs.kde.org/show_bug.cgi?id=363441
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> When "improving" the contrast of search & replace highlights, this bug slipped it.
> 
> 
> Diffs
> -----
> 
>   src/search/katesearchbar.cpp 965518c 
> 
> Diff: https://git.reviewboard.kde.org/r/128035/diff/
> 
> 
> Testing
> -------
> 
> Works now.
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160528/ce76799e/attachment.html>


More information about the Kde-frameworks-devel mailing list