Review Request 128034: KateHighlightManger::defaultStyleCount() off by one

Dominik Haumann dhaumann at kde.org
Sat May 28 12:32:29 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128034/
-----------------------------------------------------------

Review request for Kate and KDE Frameworks.


Repository: ktexteditor


Description
-------

The enum dsError should be included in the count, so we need to add 1.

With this patch, we are now able to also change the default style "Error" in the Default styles config page.

A possible other fix would be to add "dsCount" as last enum entry, and then just return KTextEditor::dsCount". Would that be a better solution? (and is adding an enum entry BC?)


Diffs
-----

  src/syntax/katesyntaxmanager.cpp 6d4b80e 

Diff: https://git.reviewboard.kde.org/r/128034/diff/


Testing
-------

Works, whereas prior to this patch, I was not able to change the color or any other attribute of dsError.


Thanks,

Dominik Haumann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160528/06dc415e/attachment.html>


More information about the Kde-frameworks-devel mailing list