Review Request 127997: Extend KNS3::Entry public API

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127997/#review95866
-----------------------------------------------------------



Sorry I missed the initial review request somehow. This looks good to me except for homepage. Homepage sounds to me like a web site url that gives more information about the KNS::Entry. Is that what you're using it for, or is it the download url of the asset? If the latter I suggest renaming homepage to url or downloadUrl or something more fitting. If the former, it looks good to me ship it.

- Jeremy Whiting


On May 24, 2016, 5:25 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127997/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 5:25 a.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Exposes some API present in either EntryInternal or in Attica::Contents.
> 
> This allows Discover's KNS Backend to just use KNewStuff entries instead of having to additionally fetch the information in Attica.
> 
> 
> Diffs
> -----
> 
>   src/attica/atticaprovider.cpp 07508b0 
>   src/core/entryinternal.cpp b05fe24 
>   src/core/entryinternal_p.h 20f9b1b 
>   src/entry.h 6603e97 
>   src/entry.cpp 09f9542 
> 
> Diff: https://git.reviewboard.kde.org/r/127997/diff/
> 
> 
> Testing
> -------
> 
> Discover works as it used to, with many changes I have locally.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160526/36133962/attachment-0001.html>