Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

Gleb Popov 6yearold at gmail.com
Thu May 26 07:58:59 UTC 2016



> On May 26, 2016, 10:56 a.m., David Faure wrote:
> > Thanks, looks good to me now, please push.
> > 
> > I'm just wondering if the "KF6 TODO" is actually feasible...

> wondering if the "KF6 TODO" is actually feasible

Can't comment on that, it's Alex' code, after all.

> Note that this requires simple Doxyfile to generate.

What about this? This is what my doxyfile looks like:

```
MACRO_EXPANSION        = YES
EXPAND_ONLY_PREDEF=    = YES
PREDEFINED=            = DOXYGEN_SHOULD_SKIP_THIS
EXPAND_AS_DEFINED      = KSTANDARDACTION_WITH_NEW_STYLE_CONNECT
```


- Gleb


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128011/#review95810
-----------------------------------------------------------


On May 26, 2016, 10:25 a.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128011/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 10:25 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> This is https://git.reviewboard.kde.org/r/121218/ review brought in shape. I couldn't update diff there, so created new request.
> 
> What the generated docs looks like can be viewed there: http://arrowd.name/html/namespace_k_standard_action.html
> 
> Note that this requires simple Doxyfile to generate. How this should be handled?
> 
> 
> Diffs
> -----
> 
>   autotests/kstandardactiontest.h 0008d28 
>   autotests/kstandardactiontest.cpp 09ae35d 
>   src/kstandardaction.h d511778 
>   src/kstandardaction.cpp 216d3d6 
> 
> Diff: https://git.reviewboard.kde.org/r/128011/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160526/1572422b/attachment.html>


More information about the Kde-frameworks-devel mailing list