Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128011/#review95805
-----------------------------------------------------------




src/kstandardaction.h (line 258)
<https://git.reviewboard.kde.org/r/128011/#comment64828>

    Isn't the return value a QAction* rather than a QObject* ?



src/kstandardaction.h (line 909)
<https://git.reviewboard.kde.org/r/128011/#comment64827>

    The DOXYGEN_SHOULD_SKIP_THIS version if missing for this one


- David Faure


On May 25, 2016, 12:23 p.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128011/
> -----------------------------------------------------------
> 
> (Updated May 25, 2016, 12:23 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> This is https://git.reviewboard.kde.org/r/121218/ review brought in shape. I couldn't update diff there, so created new request.
> 
> What the generated docs looks like can be viewed there: http://arrowd.name/html/namespace_k_standard_action.html
> 
> Note that this requires simple Doxyfile to generate. How this should be handled?
> 
> 
> Diffs
> -----
> 
>   autotests/kstandardactiontest.h 0008d28 
>   autotests/kstandardactiontest.cpp 09ae35d 
>   src/kstandardaction.h d511778 
>   src/kstandardaction.cpp 216d3d6 
> 
> Diff: https://git.reviewboard.kde.org/r/128011/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160526/ccc15b44/attachment.html>