Review Request 128014: [KToggleToolBarAction] Honor action/options_show_toolbar restriction
David Edmundson
david at davidedmundson.co.uk
Wed May 25 16:59:48 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128014/#review95784
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On May 25, 2016, 3:01 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128014/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 3:01 p.m.)
>
>
> Review request for KDE Frameworks and David Edmundson.
>
>
> Repository: kxmlgui
>
>
> Description
> -------
>
> This makes sure the user is never presented the option to hide the toolbar. Toolbars could still be hidden by unlocking toolbars after which a toolbar action may show up.
>
>
> Diffs
> -----
>
> src/ktoggletoolbaraction.cpp ceb6d43
>
> Diff: https://git.reviewboard.kde.org/r/128014/diff/
>
>
> Testing
> -------
>
> Option no longer shows up. (Should've probably also hidden the Qt action in my previous patch since that's what KAuthorized usually does)
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160525/85d5aef4/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list