Review Request 128005: fix alignment issue with the OS X native "macintosh" style

Marko Käning mk-lists at mailbox.org
Tue May 24 19:52:33 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128005/#review95754
-----------------------------------------------------------


Ship it!




Hi René,

nice to see that you finally found a solution for this old problem!

Congrats,
Marko

- Marko Käning


On May 24, 2016, 6:39 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128005/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 6:39 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> This patch fixes the size & alignment issue discussed in https://bugs.kde.org/show_bug.cgi?id=296810
> 
> 
> Diffs
> -----
> 
>   src/kmultitabbar.cpp f7739fa 
> 
> Diff: https://git.reviewboard.kde.org/r/128005/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with KF5 5.20.0, Qt 5.6.0 and Kate 16.4.01 . No adverse effects when used with other themes on this platform.
> 
> 
> File Attachments
> ----------------
> 
> Kate5 running with the native "macintosh" qpa & theme, showing correct alignment.
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/fe90cba8-f6de-4e5c-8732-4cbebf4abe8b__Screen_Shot_2016-05-24_at_18.38.16.png
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160524/89ca81fb/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list