Review Request 128002: address alignment issue with the OS X native "macintosh" style
René J.V. Bertin
rjvbertin at gmail.com
Tue May 24 12:50:38 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128002/
-----------------------------------------------------------
Review request for KDE Software on Mac OS X and KDE Frameworks.
Repository: kio
Description
-------
This patch addresses a misalignment issue in KUrlNavigator when using the native "macintosh" widget style on OS X.
Cf. https://bugs.kde.org/show_bug.cgi?id=296845
Diffs
-----
src/filewidgets/kurlnavigatorbuttonbase.cpp 8b06bfa
Diff: https://git.reviewboard.kde.org/r/128002/diff/
Testing
-------
On OS X 10.9 with frameworks 5.20.0 (sic), Qt 5.6.0 using my MacPorts build.
The additional attribute doesn't have any effects for me with other styles, but this still has to be verified on other platforms.
File Attachments
----------------
The widget concerned in Kate's interface, showing the result with and without the patch. It is clear which is which.
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/ca3c7872-68ee-4ed6-b1f4-4d0b05111be1__Screen_Shot_2016-05-24_at_14.37.43.png
other widgets remain to be done
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/71b20243-8dda-4f22-89e1-21559b767fd5__Screen_Shot_2016-05-24_at_14.38.30.png
Thanks,
René J.V. Bertin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160524/b4a6fb2f/attachment.html>
More information about the Kde-frameworks-devel
mailing list