Review Request 127925: KWalletd migration: fix error handling.

Martin Klapetek martin.klapetek at gmail.com
Mon May 23 16:39:43 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127925/#review95723
-----------------------------------------------------------


Ship it!




Ship It!

- Martin Klapetek


On May 15, 2016, 11:49 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127925/
> -----------------------------------------------------------
> 
> (Updated May 15, 2016, 11:49 a.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> After a successful migration, performMigration() returns true,
> so the qDebug "failed" was wrong, and the "ok" bool should be set to
> true so that isMigrationWizardOk() returns true.
> 
> This stops the migration from happening on every single boot.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/migrationagent.cpp 217d4a8485863835819d9b2cd3ed08b0829fce7f 
> 
> Diff: https://git.reviewboard.kde.org/r/127925/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160523/eebbc59e/attachment.html>


More information about the Kde-frameworks-devel mailing list