Review Request 121218: Allow using new style connect syntax with KStandardAction::create()
Gleb Popov
6yearold at gmail.com
Sat May 21 04:44:23 UTC 2016
> On April 5, 2015, 5:26 p.m., David Faure wrote:
> > Well, +1 for the idea. But I wonder what the apidox will look like, the macro+template probably don't make it work.
> >
> > Also missing @since 5.10.
> >
> > Ship it from me once the apidox issue is resolved.
What apidox issue is being talked about? If it is about `KSTANDARDACTION_WITH_NEW_STYLE_CONNECT`, then i was able to make it work with some simple Doxyfile options.
See `save()` overload for example: http://arrowd.name/html/namespace_k_standard_action.html#abd0ad3c1f3ee5c9d2ff068a06c8a6ac1 and http://arrowd.name/html/namespace_k_standard_action.html#a92c0df356ef011d4a7ae9a844d4a0bc7
If this is OK, i can document all new connects with `@since@` too. Can this be commited then?
- Gleb
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121218/#review78527
-----------------------------------------------------------
On Dec. 24, 2014, 4:23 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121218/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2014, 4:23 p.m.)
>
>
> Review request for KDE Frameworks, David Faure and Nicolás Alvarez.
>
>
> Repository: kconfigwidgets
>
>
> Description
> -------
>
> Not sure if MSVC has the necessary type_traits working, but can't test that now since it don't have a Windows machine available.
>
>
> Diffs
> -----
>
> autotests/kstandardactiontest.h 0008d281c0353e872feb7483c75762a0012a7b76
> autotests/kstandardactiontest.cpp 09ae35db05467d61b8baf50fac70c6228e324492
> src/kstandardaction.h d511778b7a24b1ec2e546949dab21f1ec2fea96f
> src/kstandardaction.cpp e5bea7965032355501b4c238e37abcc0f883c0b7
>
> Diff: https://git.reviewboard.kde.org/r/121218/diff/
>
>
> Testing
> -------
>
> The newly added unit test passes
>
>
> Thanks,
>
> Alex Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160521/b9f66c34/attachment.html>
More information about the Kde-frameworks-devel
mailing list