Review Request 127972: Always update the Predicate parser from y/l sources

[Pino Toscano]

> On May 19, 2016, 10:30 p.m., Aleix Pol Gonzalez wrote:
> > This has been like this for years. Has any of the premises changed?
> 
> Michael Pyne wrote:
>     I think it's a good idea, if only to keep up with changes to the generated sources to account for things like undefined behavior fixes, fixes for new compiler warnings, etc. Some of our users will build with updated bison/flex (and I believe they're both required for KHTML still already) so it's best to limit the number of different versions of generated parsers out there, IMHO.

Before this RR, I fixed with commit b3d52004b0f1af0abd0a2ca907a7c857293dce36 the predicate grammar, which was producing a non-compiling source; also, the current `UpdateSolidPredicateParser` rule is broken. These led me thinking that nobody really run the rule in years, which is not good.

Additionally, generated sources added statically in the source tree is really a bad idea.


- Pino


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127972/#review95629
-----------------------------------------------------------


On May 19, 2016, 10:19 p.m., Pino Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127972/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 10:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Lukáš Tinkl.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> Turn Flex and Bison into required build dependencies, and use them to always regenerate at build time the Predicate parser. This ensures that the parser does not rot, and there is no more need to rely on autogenerated sources added statically among the others.
> 
> Second commit: remove old generated files of Predicate parser
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741 
>   src/solid/CMakeLists.txt f2b43b27cb47531ed57b2eccafad8e67951b56b9 
>   src/solid/devices/CMakeLists.txt 9271ae1e36b67b112be54a6ff9c6fb76a8a0a824 
>   src/solid/devices/predicate_lexer.c 3b5a0b90907baf1cd2631da4de650ec153d0f642 
>   src/solid/devices/predicate_parser.h 68e25070d498f5a635489af51f4b772c5f374108 
>   src/solid/devices/predicate_parser.c 6d35ff25f001a43cbfecacc11e7d7591bb4808f9 
> 
> Diff: https://git.reviewboard.kde.org/r/127972/diff/
> 
> 
> Testing
> -------
> 
> Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160520/e1921bea/attachment.html>