Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/
-----------------------------------------------------------

(Updated Mai 19, 2016, 9:35 nachm.)


Review request for KDE Frameworks and Plasma.


Changes
-------

* Added screenshot of the menu

The menu is created by QMainWindow when you right-click an empty area in the window. Its createPopupMenu() is virtual but we cannot subclass it in KMainWindow without breaking ABI


Repository: kxmlgui


Description
-------

While KXmlGui makes sure to prevent the user from hiding toolbars when not allowed, right-clicking an empty space in a QMainWindow, such as the menu bar, will yield a menu created by Qt, which knows nothing about Kiosk restrictions, listing all toolbar toggle actions of this window.


Diffs
-----

  autotests/ktoolbar_unittest.cpp d6c1e05 
  src/ktoolbar.cpp 8fcb9cb 

Diff: https://git.reviewboard.kde.org/r/127971/diff/


Testing
-------

Comes with a unittest.

I can no longer hide the main toolbar in Dolphin or Gwenview when this action is restricted by simply right-clicking the menu bar.


File Attachments (updated)
----------------

The Menu
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/19/076745b4-03a2-400f-9506-46999d4ce1e1__toolbartoggle.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160519/5161c72a/attachment.html>