Review Request 127948: Avoid skipping KAuthorized check

[Matthew Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127948/#review95627
-----------------------------------------------------------


Fix it, then Ship it!




Excellent, thanks!  Just one comment below about the name of the test.  If that name is good with you, feel free to change + push.


autotests/kdesktopfiletest.h (line 36)
<https://git.reviewboard.kde.org/r/127948/#comment64774>

    Can you change this name to ```testTryExecWithAuthorizeAction```?  testTryExec sound like it is testing TryExec in general, which is being tested above.  That name is hopefully a little more descriptive of the issue under test.


- Matthew Dawson


On May 19, 2016, 4:17 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127948/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 4:17 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Previously, if a .desktop file had a TryExec and a X-KDE-AuthorizeAction
> entry we would skip the KAuthorized check. This is clearly wrong.
> 
> 
> Diffs
> -----
> 
>   autotests/kdesktopfiletest.h f4e0c96b8751b2b116b98a52553ad6698b9d40b4 
>   autotests/kdesktopfiletest.cpp a90faf3ca44b6a8f5d7d7c9de4d58d17ba360d16 
>   src/core/kdesktopfile.cpp eda7c292da9aa2bc97f6066e90034767134c2e07 
> 
> Diff: https://git.reviewboard.kde.org/r/127948/diff/
> 
> 
> Testing
> -------
> 
> Disabled shell_access in kde5rc.
> 
> With I was unable to open konsole from kicker.
> Opening dolphin still worked as normal.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160519/b3182feb/attachment.html>