Review Request 127961: Adding missing license

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127961/#review95621
-----------------------------------------------------------



I would prefer that we properly investigate each of the cases. E.g. plasma-framework showed that the files are just incorrectly licensed.

- Martin Gräßlin


On May 19, 2016, 2:51 p.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127961/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 2:51 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
> some parts of the code are under a LGPL-2 only license and the LGPL
> license requires shipping the full text with the source code.
> 
> The list of LGPL-2 only files is:
>  autotests/globalcleanuptest.cpp
>  autotests/kconfigafterkglobaltest1.cpp
>  autotests/kconfigafterkglobaltest2.cpp
>  autotests/kglobalsettingstest.h
>  autotests/kglobaltest.cpp
>  autotests/klibloadertest.cpp
>  autotests/klibloadertest.h
>  autotests/klibloadertest3_module.cpp
>  autotests/klibloadertest3_module.h
>  autotests/klibloadertest5_module.cpp
>  autotests/klibloadertest5_module.h
>  autotests/klocaletest.cpp
>  autotests/klocaletest.h
>  autotests/klockfiletest.cpp
>  autotests/klockfiletest.h
>  autotests/ksavefiletest.cpp
>  autotests/ksavefiletest.h
>  autotests/kstandarddirstest.cpp
>  autotests/kstandarddirstest.h
>  autotests/ktempdirtest.cpp
>  autotests/kuniqueapptest.cpp
>  autotests/kurltest.cpp
>  autotests/kurltest.h
>  src/kdecore/kcmdlineargs.cpp
>  src/kdecore/kcmdlineargs.h
>  src/kdecore/kcomponentdata.cpp
>  src/kdecore/kcomponentdata.h
>  src/kdecore/kcomponentdata_p.h
>  src/kdecore/kde_file.h
>  src/kdecore/kde_file_win.cpp
>  src/kdecore/kglobal.cpp
>  src/kdecore/kglobal.h
>  src/kdecore/kkernel_mac.cpp
>  src/kdecore/kkernel_mac.h
>  src/kdecore/kkernel_win.cpp
>  src/kdecore/kkernel_win.h
>  src/kdecore/klibloader.cpp
>  src/kdecore/klibloader.h
>  src/kdecore/klibrary.cpp
>  src/kdecore/klibrary.h
>  src/kdecore/klockfile.h
>  src/kdecore/klockfile_unix.cpp
>  src/kdecore/klockfile_win.cpp
>  src/kdecore/kmd5.cpp
>  src/kdecore/kmd5.h
>  src/kdecore/kmimetype.cpp
>  src/kdecore/kmimetype.h
>  src/kdecore/kmimetype_p.h
>  src/kdecore/ksavefile.cpp
>  src/kdecore/ksavefile.h
>  src/kdecore/kstandarddirs.cpp
>  src/kdecore/kstringhandler_deprecated.h
>  src/kdecore/ktempdir.cpp
>  src/kdecore/ktempdir.h
>  src/kdecore/qtest_kde.cpp
>  src/kdecore/qtest_kde.h
>  src/kdeui/k3icon.cpp
>  src/kdeui/k3icon_p.h
>  src/kdeui/k4timezonewidget.cpp
>  src/kdeui/k4timezonewidget.h
>  src/kdeui/kaction.cpp
>  src/kdeui/kaction.h
>  src/kdeui/kaction_p.h
>  src/kdeui/kapplication_win.cpp
>  src/kdeui/karrowbutton.cpp
>  src/kdeui/karrowbutton.h
>  src/kdeui/kcolorchoosermode.cpp
>  src/kdeui/kcolorchoosermode_p.h
>  src/kdeui/kcolorhelpers.cpp
>  src/kdeui/kdatetimewidget.cpp
>  src/kdeui/kdatetimewidget.h
>  src/kdeui/kdatewidget.cpp
>  src/kdeui/kdatewidget.h
>  src/kdeui/kdialog_p.h
>  src/kdeui/kglobalsettings.cpp
>  src/kdeui/kglobalsettings.h
>  src/kdeui/khbox.cpp
>  src/kdeui/khbox.h
>  src/kdeui/kicon.cpp
>  src/kdeui/kicon.h
>  src/kdeui/klistwidget.cpp
>  src/kdeui/klistwidget.h
>  src/kdeui/kmenu.cpp
>  src/kdeui/kmenu.h
>  src/kdeui/kmessagebox_queued.cpp
>  src/kdeui/kmessagebox_queued.h
>  src/kdeui/kmessageboxmessagehandler.cpp
>  src/kdeui/kmessageboxmessagehandler.h
>  src/kdeui/kpassivepopupmessagehandler.cpp
>  src/kdeui/kpassivepopupmessagehandler.h
>  src/kdeui/kpixmapcache.cpp
>  src/kdeui/kpixmapcache.h
>  src/kdeui/kprogressdialog.cpp
>  src/kdeui/kprogressdialog.h
>  src/kdeui/kstringvalidator.cpp
>  src/kdeui/kstringvalidator.h
>  src/kdeui/ksystemtrayicon.h
>  src/kdeui/kvbox.cpp
>  src/kdeui/kvbox.h
>  src/kio/kdevicelistitem.cpp
>  src/kio/kdevicelistitem_p.h
>  src/kio/kdevicelistmodel.cpp
>  src/kio/kdevicelistmodel.h
>  src/kio/kdirselectdialog.cpp
>  src/kio/kdirselectdialog.h
>  src/kio/kdiskfreespace.cpp
>  src/kio/kdiskfreespace.h
>  src/kio/kfilemetainfowidget.cpp
>  src/kio/kfilemetainfowidget.h
>  src/kio/kfileshare.cpp
>  src/kio/kfileshare.h
>  src/kio/kfileshare_p.h
>  src/kio/kmetaprops.cpp
>  src/kio/kmetaprops.h
>  src/kio/kpreviewprops.cpp
>  src/kio/kpreviewprops.h
>  src/kio/metainfojob.cpp
>  src/kio/metainfojob.h
>  src/kio/passworddialog.cpp
>  src/kio/passworddialog.h
>  src/kioslave/metainfo/metainfo.cpp
>  src/kioslave/metainfo/metainfo.h
>  src/kssl/kopenssl.cpp
>  src/kssl/kopenssl.h
>  src/solid-networkstatus/kded/wicdcustomtypes.cpp
>  src/solid-networkstatus/kded/wicdcustomtypes.h
>  tests/kmessagetest.cpp
>  tests/kmessagetest.h
>  tests/netaccesstest.cpp
> 
> 
> Diffs
> -----
> 
>   COPYING.LGPL-2 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127961/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160519/bafec452/attachment-0001.html>