Review Request 127870: plasma-framework: AppletInterface::downloadPath()

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127870/#review95613
-----------------------------------------------------------




src/scriptengines/qml/plasmoid/appletinterface.h (line 279)
<https://git.reviewboard.kde.org/r/127870/#comment64771>

    If at it, shouldn't this be const?


- Kai Uwe Broulik


On Mai 8, 2016, 4:15 nachm., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127870/
> -----------------------------------------------------------
> 
> (Updated Mai 8, 2016, 4:15 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Deprecate downloadPath(const QString &file) in favor of downloadPath() since the file argument is not used.
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 6cf71aa 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 876af2c 
> 
> Diff: https://git.reviewboard.kde.org/r/127870/diff/
> 
> 
> Testing
> -------
> 
> compiles. make test still passes.
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160519/ef3aa25c/attachment.html>