Review Request 127887: Improve usage of Qt APIs

[Aleix Pol Gonzalez]

> On May 17, 2016, 10:46 p.m., Gregor Mi wrote:
> > src/core/installation.cpp, line 383
> > <https://git.reviewboard.kde.org/r/127887/diff/2/?file=464635#file464635line383>
> >
> >     I don't know if this does the same but also didn't test.

It uses QStandardPaths to actively look-up instead of taking a random first directory. This will return the `GenericDataLocation` directory named `targetDirectory` as requested.


> On May 17, 2016, 10:46 p.m., Gregor Mi wrote:
> > src/kmoretools/kmoretoolsconfigdialog_p.cpp, line 201
> > <https://git.reviewboard.kde.org/r/127887/diff/2/?file=464638#file464638line201>
> >
> >     I wonder why here "for" is better than Q_FOREACH.

Because notInstalledServices is not a Qt container and `foreach` doesn't deal well with them.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127887/#review95561
-----------------------------------------------------------


On May 12, 2016, 1:01 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127887/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 1:01 a.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Mostly clazy fixes, few cleanups
> 
> 
> Diffs
> -----
> 
>   src/core/installation.cpp 1887d0f 
>   src/kmoretools/kmoretools.h 32da22c 
>   src/kmoretools/kmoretools.cpp 8bd6751 
>   src/kmoretools/kmoretoolsconfigdialog_p.cpp 466b887 
>   src/kmoretools/kmoretoolsmenufactory.cpp aad3f00 
>   src/kmoretools/kmoretoolspresets.cpp 679e849 
>   src/staticxml/staticxmlprovider.cpp 541bf57 
>   src/ui/itemsviewdelegate.cpp 7001be2 
>   tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea 
> 
> Diff: https://git.reviewboard.kde.org/r/127887/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160518/cc6d0cd7/attachment.html>