Review Request 127809: [Platform xcb] Get best icon size when he's not specified

[Martin Gräßlin]

> On May 17, 2016, 4:44 p.m., Martin Gräßlin wrote:
> > src/platforms/xcb/kwindowsystem.cpp, lines 730-732
> > <https://git.reviewboard.kde.org/r/127809/diff/5/?file=464409#file464409line730>
> >
> >     this change looks not really needed. Looking at the code I think there is no change at all. Instead of having each segment in if (result.isNull()) there is now a if (!result.isNull()) { return result; }
> >     
> >     That looks pretty much the same, so I think we could just focus on the icon size change.
> 
> Anthony Fieroni wrote:
>     It's because below you have
>     if (flags & KWindowSystem::XApp) {
>         if (result.isNull()) {
>     So if you have KWindowSystem::XApp setted and result is not Null, this is 2 conditions when you can return with only one. It's a bit of optimization, i can revert it.

That's a micro optimization then. I would suggest to revert the part so that it's only about what matters.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127809/#review95540
-----------------------------------------------------------


On May 6, 2016, 11:08 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127809/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 11:08 a.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Martin Gräßlin.
> 
> 
> Bugs: 362324
>     https://bugs.kde.org/show_bug.cgi?id=362324
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> The api function is KWindowSystem::icon (WId win, int width=-1, int height=-1, bool scale=false) so caller must get best size not worst when width/height is not specified.
> 
> 
> Diffs
> -----
> 
>   src/platforms/xcb/kwindowsystem.cpp 5b7c65a 
> 
> Diff: https://git.reviewboard.kde.org/r/127809/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/6d718ef6-26cf-4866-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png
> after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160518/b94b4f42/attachment.html>