Review Request 127948: Avoid skipping KAuthorized check

[David Edmundson]

> On May 17, 2016, 8:12 p.m., Kai Uwe Broulik wrote:
> > +1
> > 
> > Dolphin probably uses KRun which uses KDesktopFile::isAuthorizedDesktopFile which does not check for X-KDE-AuthorizeAction

With the comment about Dolphin, I simply meant I had tested that I hadn't broken the normal case and that we could still load other apps (firefox, dolphin, kate whatever)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127948/#review95556
-----------------------------------------------------------


On May 17, 2016, 7:57 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127948/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 7:57 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Previously, if a .desktop file had a TryExec and a X-KDE-AuthorizeAction
> entry we would skip the KAuthorized check. This is clearly wrong.
> 
> 
> Diffs
> -----
> 
>   src/core/kdesktopfile.cpp eda7c292da9aa2bc97f6066e90034767134c2e07 
> 
> Diff: https://git.reviewboard.kde.org/r/127948/diff/
> 
> 
> Testing
> -------
> 
> Disabled shell_access in kde5rc.
> 
> With I was unable to open konsole from kicker.
> Opening dolphin still worked as normal.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160517/564e7efd/attachment-0001.html>