Review Request 127923: Add support for custom emoticon sizes

Martin Klapetek martin.klapetek at gmail.com
Tue May 17 03:27:13 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127923/
-----------------------------------------------------------

(Updated May 17, 2016, 5:27 a.m.)


Review request for KDE Frameworks and David Gil Oliva.


Changes
-------

Merge the first two arg()


Repository: kemoticons


Description
-------

Right now KEmoticonTheme::parse always returns the emoticons
sized by the actual image file size, but there are cases where
different size is needed, for example when parsing emoticons
inline in a text area while typing.

This also allows to ship bigger emoticon images and have them
scaled down as/when needed.


Diffs (updated)
-----

  autotests/kemoticontest.cpp 4e0e539 
  src/core/kemoticons.h 4718c00 
  src/core/kemoticons.cpp 9756c1f 
  src/core/kemoticonsprovider.h d259bf8 
  src/core/kemoticonsprovider.cpp 5aabd82 

Diff: https://git.reviewboard.kde.org/r/127923/diff/


Testing
-------

Works as expected plus comes with a simple autotest.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160517/1fdae057/attachment.html>


More information about the Kde-frameworks-devel mailing list