Review Request 127941: Kio fish: cannot process any file or diretory having a non-latin1 name

[Fabien Shum-King]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127941/
-----------------------------------------------------------

(Updated May 16, 2016, 10:05 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 1876df2e3d59c3d0fdee3d3084a07175fc9a00ed by Albert Astals Cid on behalf of Fabien Shum-King to branch Applications/16.04.


Bugs: 357870
    https://bugs.kde.org/show_bug.cgi?id=357870


Repository: kio-extras


Description
-------

All the commands sent to the Fish server are converted to latin1. By consequence, all the non-latin1 characters are replaced by questions marks, and therefore any command involving a file or directory with such a name fails.


Diffs
-----

  fish/fish.cpp f0b3b79 

Diff: https://git.reviewboard.kde.org/r/127941/diff/


Testing
-------

Created on a remote machine a file and a directory with an non-latin1 name (ex: ??, éé).
1. Connect with fish and try to copy the file to the local machine => It fails
2. Try to enter the directory => it also fails.

With the proposed fix, both work.


Thanks,

Fabien Shum-King

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160516/1e18219d/attachment-0001.html>