Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127911/#review95520
-----------------------------------------------------------




CMakeLists.txt (line 24)
<https://git.reviewboard.kde.org/r/127911/#comment64740>

    Rename: Use a verb -- rename to `add_binary_resource`, or `generate_binary_resource`
    
    Params: `ret` -> `out`, or `outfile`



CMakeLists.txt (line 29)
<https://git.reviewboard.kde.org/r/127911/#comment64738>

    This action should be deferred as well. See next comment.



CMakeLists.txt (line 32)
<https://git.reviewboard.kde.org/r/127911/#comment64739>

    `cmake -E make_directory` first?


- Kevin Funk


On May 16, 2016, 6:21 a.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127911/
> -----------------------------------------------------------
> 
> (Updated May 16, 2016, 6:21 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> -------
> 
> I copied icons into the binary dir, because i haven't found a way to generate rcc without polluting source dir.
> 
> Not sure if installation dir is right, too.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2147705 
>   icons-dark/CMakeLists.txt 36d37f1 
>   icons/CMakeLists.txt 5ded49c 
> 
> Diff: https://git.reviewboard.kde.org/r/127911/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160516/0d5576ae/attachment.html>