Review Request 127935: Call kdoctools_create_handbook only for index.docbook

Luigi Toscano luigi.toscano at tiscali.it
Mon May 16 17:58:42 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127935/
-----------------------------------------------------------

(Updated Mag. 16, 2016, 7:58 p.m.)


Review request for Documentation, KDE Frameworks and Elvis Angelaccio.


Changes
-------

Try to improve the documentation.


Bugs: 357428
    https://bugs.kde.org/show_bug.cgi?id=357428


Repository: kdoctools


Description
-------

When more documentation files are available in a certain directory, the assumption is that there should always be an index.docbook which
imports all the other docbook files in the same directory. The call to kdoctools_create_handbook must be created only for index.docbook;
the macro takes care of the installation of the others docbooks. 
This should make kdoctools_install work when there are multiple docbooks in the same directory.


Diffs (updated)
-----

  KF5DocToolsMacros.cmake 54761b6 

Diff: https://git.reviewboard.kde.org/r/127935/diff/


Testing
-------

Tried kdoctools_install when the (translated) documentation is made of multiple docbooks (like krusader), see the bug for more details.


Thanks,

Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160516/64ca426b/attachment.html>


More information about the Kde-frameworks-devel mailing list