Review Request 127929: K4TimeZoneWidget: flag images not displayed because of incorrect path
Albert Astals Cid
aacid at kde.org
Mon May 16 10:23:27 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127929/#review95505
-----------------------------------------------------------
Ship it!
Ship It!
- Albert Astals Cid
On May 15, 2016, 1:59 p.m., Jonathan Marten wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127929/
> -----------------------------------------------------------
>
> (Updated May 15, 2016, 1:59 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs4support
>
>
> Description
> -------
>
> In KDE4 this widget displayed the appropriate country flag at the start of the continent/city column. This no longer happens because the path used to find the flag image files is incorrect: it is still using the old share/locale/l10n/CC/flag.png location. In KF5 this is now share/kf5/locale/countries/CC/flag.png. This change corrects the path and comment.
>
>
> Diffs
> -----
>
> src/kdeui/k4timezonewidget.cpp 70ff79f
>
> Diff: https://git.reviewboard.kde.org/r/127929/diff/
>
>
> Testing
> -------
>
> Built kdelibs4support with this change, checked correct display of flag column in dialogue.
>
>
> Thanks,
>
> Jonathan Marten
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160516/02ba7283/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list