Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

[Kåre Särs]

> On May 15, 2016, 5:03 p.m., Kåre Särs wrote:
> > Looks good :) A couple of questions:
> > 
> > - If we create the .rcc do we also want to install the icons?
> > - I creates a similar solution for Kate on Windows (in a separate repo), but I needed to add a program to replace the symlinked files with aliases in the .qrc as symlinks do not work properly on windows. Are you interested in adding a similar program/script/... to do the same directly in breeze-icons.git? My application is in git://anongit.kde.org/scratch/sars/kate-windows.git (icon-rcc)
> 
> Gleb Popov wrote:
>     > If we create the .rcc do we also want to install the icons?
>     
>     No idea, to be honest.
>     
>     > I creates a similar solution for Kate on Windows (in a separate repo), but I needed to add a program to replace the symlinked files with aliases in the .qrc as symlinks do not work properly on windows
>     
>     Sorry, what symlinks? I saw some symlinks stuff in autotests, but didn't get what it is all about.

Quite a lot of icons in breeze-icons are just symbolic links to other icons in the repository. On Linux/OSX/Android/... this is not a problem, but on Windows, where you don't have proper symbolic links, git just creates a text file with the path to the target file. With those text files you just don't get an icon :( So my solution was to create an application to modify the .qrc file add an alias to the target file in stead of using the symbolic link file directly.

Don't let this comment be in the way of committing this RR :)


- Kåre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127911/#review95485
-----------------------------------------------------------


On May 16, 2016, 6:21 a.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127911/
> -----------------------------------------------------------
> 
> (Updated May 16, 2016, 6:21 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> -------
> 
> I copied icons into the binary dir, because i haven't found a way to generate rcc without polluting source dir.
> 
> Not sure if installation dir is right, too.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2147705 
>   icons-dark/CMakeLists.txt 36d37f1 
>   icons/CMakeLists.txt 5ded49c 
> 
> Diff: https://git.reviewboard.kde.org/r/127911/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160516/c94356a5/attachment.html>