Review Request 127931: Kdelibs4ConfigMigrator: skip reparsing if nothing was migrated.
David Faure
faure at kde.org
Sun May 15 16:55:30 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127931/
-----------------------------------------------------------
Review request for KDE Frameworks and Laurent Montel.
Repository: kcoreaddons
Description
-------
This improves performance greatly for crazy PIM people calling
this code in an often-called constructor :-)
Diffs
-----
src/lib/util/kdelibs4configmigrator.cpp acdb19cfd84b46a1a6e4cf1ead3a32354145e7ae
Diff: https://git.reviewboard.kde.org/r/127931/diff/
Testing
-------
Found by callgrind'ing kmail. Not actually tested other than compilation and kcoreaddons unit tests, but seems clear enough.
Thanks,
David Faure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160515/e3546044/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list