Review Request 127923: Add support for custom emoticon sizes

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127923/#review95476
-----------------------------------------------------------



+1


src/core/kemoticonsprovider.cpp (line 155)
<https://git.reviewboard.kde.org/r/127923/#comment64726>

    .arg(escaped, path).arg...


- Aleix Pol Gonzalez


On May 15, 2016, 5:55 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127923/
> -----------------------------------------------------------
> 
> (Updated May 15, 2016, 5:55 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> -------
> 
> Right now KEmoticonTheme::parse always returns the emoticons
> sized by the actual image file size, but there are cases where
> different size is needed, for example when parsing emoticons
> inline in a text area while typing.
> 
> This also allows to ship bigger emoticon images and have them
> scaled down as/when needed.
> 
> 
> Diffs
> -----
> 
>   autotests/kemoticontest.cpp 4e0e539 
>   src/core/kemoticons.h 4718c00 
>   src/core/kemoticons.cpp 9756c1f 
>   src/core/kemoticonsprovider.h d259bf8 
>   src/core/kemoticonsprovider.cpp 5aabd82 
> 
> Diff: https://git.reviewboard.kde.org/r/127923/diff/
> 
> 
> Testing
> -------
> 
> Works as expected plus comes with a simple autotest.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160515/dc538636/attachment-0001.html>