Review Request 127905: refine current icon theme heuristics

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127905/#review95450
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On May 13, 2016, 1:43 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127905/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 1:43 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck and Marco Martin.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> this is to prevent incorrect default themes when a themeplugin is
> available
> 
> current icon theme is now decided as follows
> - application config contains Icons/Theme config
> - QIcon has a theme set
> - kdelogbals config contains Icons/Theme config
> - hard coded default
> 
> for all these steps hicolor is excluded as valid option as it is not a
> complete icon theme on its own, so we'd rather have the hardcoded default
> intead of plain hicolor (since we inherit hicolor anyway)
> 
> This improves icon theming in the following ways
> a) without kdeglobals we don't always end up using the default (oxygen)
> b) with a theme plugin any environment can force a theme different from
>    what is set in kdeglobals. this in particular would for example allow
>    xfce/gnome/unity to have a platform plugin and use the correct icons
>    even when the application uses kiconthemes.
> 
> a) in particular was causing the entire workspace on first login to use
> oxygen if startup was too fast so that kde4breeze would not have written
> a kdeglobals file with Theme=breeze by the time plasma started.
> 
> 
> Diffs
> -----
> 
>   src/kicontheme.cpp 23bbb4e8010691fcfb1d3af386c0eab10dc91385 
> 
> Diff: https://git.reviewboard.kde.org/r/127905/diff/
> 
> 
> Testing
> -------
> 
> test all scenarios.
> 
> unfortunately I couln't figure out a way to take the theme plugin out of the equation to unit test this consistently even when a theme plugin is available
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160513/c02dff5b/attachment.html>