Review Request 127850: Let Plasma::Corona load the layout on all cases.

Aleix Pol Gonzalez aleixpol at kde.org
Wed May 11 23:20:01 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/
-----------------------------------------------------------

(Updated May 12, 2016, 1:20 a.m.)


Review request for KDE Frameworks, Plasma and David Rosca.


Changes
-------

Looked into the issue again, we shouldn't be notifying the startup completed only because the script finished. This re-uses the same code for both cases and fixes Plasma 5.5 and 5.6 without touching them.


Bugs: 60777
    http://bugs.kde.org/show_bug.cgi?id=60777


Repository: plasma-framework


Description
-------

Iteration of: https://git.reviewboard.kde.org/r/127848/

We either load the existing layout or we load a default one.

With this, it could be removed from ShellCorona.


Diffs (updated)
-----

  src/plasma/corona.h d8f829a 
  src/plasma/corona.cpp 1784516 

Diff: https://git.reviewboard.kde.org/r/127850/diff/


Testing
-------

Tests pass.
PlasmaShell prints completed once both with and without configuration.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160511/8eb4bf89/attachment.html>


More information about the Kde-frameworks-devel mailing list