Review Request 127878: use the "selected" icon mode in file open dialog sidebar

Marco Martin notmart at gmail.com
Tue May 10 11:57:52 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127878/
-----------------------------------------------------------

(Updated May 10, 2016, 11:57 a.m.)


Review request for KDE Frameworks and Plasma.


Repository: kio


Description
-------

since now kiconloader can color the icons in the sidebar, by using the "selected" icon mode, when the breeze icon theme is used the icon of the current sidebar item will be of the same color of selected text (white-ish by default), is more in line with breeze style and the monochrome icons become more readable


Diffs (updated)
-----

  src/filewidgets/kfileplacesview.cpp 03074e0 
  src/widgets/kfileitemdelegate.cpp 1516b9e 

Diff: https://git.reviewboard.kde.org/r/127878/diff/


Testing
-------


File Attachments
----------------

menu3.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/41f52d86-6fc5-4799-bd9e-18d17dc5a65a__menu3.png


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160510/bc59fc58/attachment.html>


More information about the Kde-frameworks-devel mailing list