Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

Andreas Kainz kainz.a at gmail.com
Mon May 9 22:22:16 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127876/#review95312
-----------------------------------------------------------


Ship it!




I can't review the code but this is one of the best features in the past 2 years
+1 from the vdg

- Andreas Kainz


On Mai 9, 2016, 3:32 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127876/
> -----------------------------------------------------------
> 
> (Updated Mai 9, 2016, 3:32 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> with the stylesheet based recoloring for icons, it is possible to make selected icons the same color as the selected text from the palette.
> with the breeze icons style this makes the selected item more readable and more in line with the style.
> 
> 
> Diffs
> -----
> 
>   kstyle/breezestyle.cpp 403771c 
> 
> Diff: https://git.reviewboard.kde.org/r/127876/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> menu.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/cfbb4571-ed40-411e-ad89-453d29fa2610__menu.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160509/63f5b6ea/attachment.html>


More information about the Kde-frameworks-devel mailing list