Review Request 127875: Selected state concept for icons

[Kai Uwe Broulik]

> On Mai 9, 2016, 10:32 nachm., David Edmundson wrote:
> > src/kiconloader.cpp, line 311
> > <https://git.reviewboard.kde.org/r/127875/diff/1/?file=464536#file464536line311>
> >
> >     was createIconImage in the last frameworks?
> >     
> >     if so this is an ABI break.
> >     
> >     instead of using a default argument you'll have to have two methods.

Are you sure? This is KIconLoaderPrivate


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127875/#review95297
-----------------------------------------------------------


On Mai 9, 2016, 3:26 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127875/
> -----------------------------------------------------------
> 
> (Updated Mai 9, 2016, 3:26 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> QIcon has a Selected state that wasn't mapped to KIcon, use it and in case for svg based icons that take colors from the palette take the highlightedText color from the palette to color the icon instead of the text color, making it possible for styles to have white icons and white text in selected menu items (need explicit support from the style, patches in breeze and the like coming)
> 
> 
> Diffs
> -----
> 
>   src/kiconengine.cpp 7c72ade 
>   src/kiconloader.h cf2f58a 
>   src/kiconloader.cpp b3c7166 
> 
> Diff: https://git.reviewboard.kde.org/r/127875/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> menu.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/0fb9a44c-8db4-4a10-91e7-1a6a36e41f62__menu.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160509/b9e650c4/attachment-0001.html>