KFilePlacesModelTest

[Kevin Ottens]

Hello,

Not sure I can be of any help anymore in that area, I've been way to remote 
from that code for years now. That said there's a couple of questions at the 
end I might be able to answer:

On Saturday, 7 May 2016 14:33:53 CEST David Faure wrote:
> The thing I wonder is... does it really make sense to have a model with
> random ordering? Isn't it a problem for users if their visible list of
> places is different between every run? Or am I missing something and the
> different order in the test isn't actually user visible?

Indeed it was not supposed to be user visible. The places in the list come 
from entries added by the user and devices reported by solid. Whatever the 
model saw in the past ends up in the bookmark file, which freezes the order, 
next time it shows up it'll have the same place again in the list. But if you 
got a bunch of new devices appearing, they're added at the end of the list in 
no particular order.

That was the core of the wanted behavior. Of course it could have been broken 
somewhere along the way, I passed the maintenance of that part years ago. 
Also, IIRC most of the tests aren't really clear on what's saved in the 
bookmark file or not, so some of the stuff is ordered some not really.

Hope that helps at least a bit.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160507/766e512f/attachment.sig>