Review Request 127837: oxygen_windeco: Fix potential use-after-free from improper use of QCache<QPixmap>

[Hugo Pereira Da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127837/#review95233
-----------------------------------------------------------


Ship it!




Thanks ! 
I tested it here. Looks fine.
Although the diff is hard to read, new code looks good.

Hugo

- Hugo Pereira Da Costa


On May 5, 2016, 12:23 a.m., Michael Pyne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127837/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 12:23 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: oxygen
> 
> 
> Description
> -------
> 
> oxygen windeco: Fix use-after-free for pixmap in QCache.
> 
> Coverity identified (in CID 1336171) a usage of QPixmap after it's been
> the parameter to QCache<QPixmap>::insert.
> 
> This is unsafe since QCache gains ownership of whatever object is passed
> in, and can even (at least in theory) delete the object you pass in.
> Instead give the QCache its own copy of the pixmap.
> 
> To make this work without leaking our existing pixmap we need to work
> with a QPixmap instead of QPixmap* in the non-cached case. This leads to
> whitespace changes; use git diff -b to filter pure whitespace changes
> out.
> 
> 
> Diffs
> -----
> 
>   kdecoration/oxygendecohelper.cpp a7e9306 
> 
> Diff: https://git.reviewboard.kde.org/r/127837/diff/
> 
> 
> Testing
> -------
> 
> The new code compiles but I'm currently unable to test since kcmshell5 kwindecoration (and any other KCM viewer) is currently crashing for me in QML, due to what I'm sure is a local misconfiguration...
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160506/316cba41/attachment.html>