Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

[Michael Pyne]

> On May 5, 2016, 9:15 p.m., Albert Astals Cid wrote:
> > src/runtime/kwalletd/main.cpp, line 97
> > <https://git.reviewboard.kde.org/r/127833/diff/1/?file=464146#file464146line97>
> >
> >     See REVIEW: 126681 (commit 901c27ca7cb05cca1a960747b280d40cd7707158) it seems this fixes things. So not a good idea reverting it, probably a different fix needed.

I'm fine leaving this out until we have a better fix, but it seems to me that we're only masking over the problem here. An open fd shouldn't be the difference between the event loop working or not.

Any objections to the rest?


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127833/#review95214
-----------------------------------------------------------


On May 4, 2016, 11:03 p.m., Michael Pyne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127833/
> -----------------------------------------------------------
> 
> (Updated May 4, 2016, 11:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> This is a collection of minor fixes:
> 
> An uninit variable usage was noted by Coverity (CID 1289177) for a CBC crypto function, though it only happens for encryption lengths that would not be hit in practice. I troubleshot this in December but forgot to make a RR, but IIRC the lengths that would cause problems are 7 bytes or less -- but it's still better to fix.
>     
> The other Coverity fix is to avoid a needless dup(2) of an opened socket since it's immediately turned into a FILE* object anyways (CID 1353007). This avoids a minor resource leak of a file descriptor.
> 
> Finally, some of the ciphers use Qt checks for endianness, and need to actually include the header that does this instead of relying on other parts of the code incidentally pulling in the needed #includes.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/backend/blowfish.cc a375148 
>   src/runtime/kwalletd/backend/cbc.cc 4c13466 
>   src/runtime/kwalletd/backend/sha1.cc 9d98b79 
>   src/runtime/kwalletd/main.cpp 90c60d8 
> 
> Diff: https://git.reviewboard.kde.org/r/127833/diff/
> 
> 
> Testing
> -------
> 
> Everything still compiles -- I'm limited in my ability to test since I'm still using KDE4's KWallet (as the KF5 stuff seems to require polkit to actually work, which isn't possible with a homedir install like mine).
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160506/b27c3d67/attachment.html>