Review Request 127809: [Platform xcb] Get best icon size when he's not specified

[Anthony Fieroni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127809/
-----------------------------------------------------------

(Updated Май 5, 2016, 7:50 след обяд)


Review request for KDE Frameworks, KDE Usability and Martin Gräßlin.


Changes
-------

1. Do not change function behavior
2. Find best possible icon size


Bugs: 362324
    https://bugs.kde.org/show_bug.cgi?id=362324


Repository: kwindowsystem


Description
-------

The api function is KWindowSystem::icon (WId win, int width=-1, int height=-1, bool scale=false) so caller must get best size not worst when width/height is not specified.


Diffs (updated)
-----

  src/platforms/xcb/kwindowsystem.cpp 5b7c65a 

Diff: https://git.reviewboard.kde.org/r/127809/diff/


Testing
-------


File Attachments
----------------

before
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/6d718ef6-26cf-4866-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png
after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160505/2557a657/attachment.html>