Review Request 127843: Properly remove composed characters
Jan Grulich
jgrulich at redhat.com
Thu May 5 10:05:57 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127843/
-----------------------------------------------------------
Review request for KDE Frameworks, Christoph Cullmann and Dominik Haumann.
Repository: ktexteditor
Description
-------
When using Indic locales composed characters are not properly removed. Pressing "delete" or "backspace" should remove the entire composed character and not only one base character. You can see how it should behave when using another text editor (e.g. libreoffice)
Can be tested with these words: ?????????? or ??????????? or ????????
Technical details:
I'm not really sure whether exporting current text layout is the right way to do this, I found that this is used when calling moveChar() which moves the cursor exactly by one composed character so I was trying to find a way to do it similarly.
Diffs
-----
src/document/katedocument.cpp 73778a1
src/view/kateview.h 08db0df
src/view/kateview.cpp fda6b2d
Diff: https://git.reviewboard.kde.org/r/127843/diff/
Testing
-------
Thanks,
Jan Grulich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160505/d9acc73e/attachment.html>
More information about the Kde-frameworks-devel
mailing list