Review Request 127842: take highlight and highlightedText from proper color group

Marco Martin notmart at gmail.com
Thu May 5 09:54:07 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127842/
-----------------------------------------------------------

(Updated May 5, 2016, 9:54 a.m.)


Review request for KDE Frameworks and Plasma.


Changes
-------

remove buttonhighlightedtext,viewhighlightedtext etc


as there is only one highlight color, there is also only one highlighted text color.

those entries were added after last frameworks release, so can still be removed


Repository: plasma-framework


Description
-------

lately the highlight color of plasma became a very washed-out blue, (since it switched to use the global system colors) that was because it actually taken the highlight color (and highlightedText) from the wrong source.
there is a correct color group in kcolorscheme for that, that is Selection, take those two colors from that (also means highlight and highlightedtext always be the same in all plasma::theme::colorgroups but that's not a problem)

update test to reflect that


Diffs (updated)
-----

  autotests/themetest.cpp ce512a4 
  src/declarativeimports/core/quicktheme.h ac5e121 
  src/plasma/private/theme_p.h d2246de 
  src/plasma/private/theme_p.cpp e6d55c3 

Diff: https://git.reviewboard.kde.org/r/127842/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160505/d4d5deba/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list