Review Request 127836: kwayland: Initialize Interface factory pointer to fix Coverity warning
Michael Pyne
mpyne at kde.org
Thu May 5 01:19:28 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127836/
-----------------------------------------------------------
(Updated May 5, 2016, 3:19 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and kwin.
Changes
-------
Submitted with commit f0510907d2247534b40b6176757156181ad499a0 by Michael Pyne to branch master.
Repository: kwayland
Description
-------
Coverity complains (in CID 1335150) about `Generator::parseInterface()` since the default copy-ctor for `Interface` will end up copying uninitialized memory (the unset `m_factory` member).
While this seems to just be a tool to assist in source code generation, and I don't see any instances of use of invalid factories, it's easy enough to just initialize the factory and clear the warning that way.
Diffs
-----
src/tools/generator.cpp 805d93b
Diff: https://git.reviewboard.kde.org/r/127836/diff/
Testing
-------
Still compiles, haven't done anything more.
Thanks,
Michael Pyne
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160505/3e0cfcbd/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list