Review Request 127836: kwayland: Initialize Interface factory pointer to fix Coverity warning

Michael Pyne mpyne at kde.org
Wed May 4 23:40:17 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127836/
-----------------------------------------------------------

Review request for KDE Frameworks and kwin.


Repository: kwayland


Description
-------

Coverity complains (in CID 1335150) about `Generator::parseInterface()` since the default copy-ctor for `Interface` will end up copying uninitialized memory (the unset `m_factory` member).

While this seems to just be a tool to assist in source code generation, and I don't see any instances of use of invalid factories, it's easy enough to just initialize the factory and clear the warning that way.


Diffs
-----

  src/tools/generator.cpp 805d93b 

Diff: https://git.reviewboard.kde.org/r/127836/diff/


Testing
-------

Still compiles, haven't done anything more.


Thanks,

Michael Pyne

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160504/994d2bb3/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list