Review Request 126285: OS X build and warning fix

[Ivan Čukić]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126285/#review95174
-----------------------------------------------------------


Ship it!




Looks good to me - though I can not comment on the OSX API.

- Ivan Čukić


On April 29, 2016, 11:59 a.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126285/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 11:59 a.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks and Ivan Čukić.
> 
> 
> Repository: qca
> 
> 
> Description
> -------
> 
> Revert "Add missed file"
> 
> This reverts commit 4c9f27270e0a7c00c10cbc56ce5c6842b47e5ab2.
> 
> FindCoreFoundation.cmake is not needed since CoreFoundation
> is a system framework. Its use has been removed by
> commit f223ce03d4b94ffbb093fc8be5adf8d968f54434
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 051ae6d26111725d3a296a124e8c1772e37c9940 
>   cmake/modules/FindCoreFoundation.cmake c08e529ceec337c085f2f650f180b4e7897246bb 
>   src/CMakeLists.txt a60bda0bf3d8bad7523ee7d50798c8cdb6c2eccb 
>   src/qca_systemstore_mac.cpp 9349c90c8258d3d1f00a3796d93f94c09f5b1f2a 
> 
> Diff: https://git.reviewboard.kde.org/r/126285/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160504/984828d9/attachment.html>