Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127795/#review95169
-----------------------------------------------------------




src/plasma/dataengine.cpp 
<https://git.reviewboard.kde.org/r/127795/#comment64583>

    it is in probably 99% of the cases, but technically it should still be possible for the source to either destroy itself or for somebody else to delete it.
    
    in line 304, the lines
    
    s->deleteLater();
    d->sources.erase(it);
    
    should probably be swapped, that would avoid a duplicate signal to be ever emitted, but still managing the case of self destruction of a source
    
    while on line 316 is correct already removing from the list before, then deleting the source


- Marco Martin


On May 3, 2016, 4:10 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127795/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 4:10 a.m.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   autotests/pluginloadertest.h 61fc963 
>   autotests/pluginloadertest.cpp 4f96780 
>   src/plasma/dataengine.cpp f942926 
> 
> Diff: https://git.reviewboard.kde.org/r/127795/diff/
> 
> 
> Testing
> -------
> 
> Test pass.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160504/a1809577/attachment.html>