Review Request 127756: Remove platformtheme plugin

[Bhushan Shah]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127756/#review95150
-----------------------------------------------------------


Ship it!




+1, since it is already moved to plasma-integration and also this have broken unittest.

- Bhushan Shah


On April 27, 2016, 4:46 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127756/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 4:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> The platformthem plugin got split out of frameworksintegration and
> lives in plasma-integration now. As it was for Plasma and has
> dependencies on Plasma (e.g. Breeze) it should be removed from
> frameworksintegration.
> 
> Plasma-integration had a release in the mean-time.
> Note for distributions: Don't combine this frameworksintegration with
> Plasma < 5.6!
> 
> CHANGELOG: Remove platformtheme plugin as it's in plasma-integration
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8624a986e43b8e677842c64179613c3f84d7baef 
>   autotests/CMakeLists.txt 5cbaeebe34da35f7fa7e44dfab51ce240aecca03 
>   autotests/kdeplatformtheme_changed_kdeglobals 910e0e3c89d3de7ee69cd22a6c6da6d3b0d331b0 
>   autotests/kdeplatformtheme_config.h.in c434ba29ab4f3ba85a5a9697ad2eae626268dd61 
>   autotests/kdeplatformtheme_kdeglobals df524109064d70c1679dace3881ea37ca03972c6 
>   autotests/kdeplatformtheme_unittest.cpp a830ef674c0947ffa8a0e94edcd8da5f5e566736 
>   autotests/kdirselectdialog_unittest.cpp 2f6416deb739256f1f064e7e86fce87a6d9ac165 
>   autotests/kfiledialog_unittest.cpp 59915daab24617d3017d84f3f20babe06059a378 
>   autotests/kfiledialogqml_unittest.cpp 6e3686ad131656644b0a2b399f989cb226e1f5e9 
>   autotests/kfontsettingsdata_unittest.cpp 9f21ffec746897a0e58ebd03fe9defc52a051f16 
>   autotests/ksni_unittest.cpp cabdd8b29f24da8481f460b16d77bf3f478c8b7f 
>   autotests/qml/filedialog_parentless.qml c1c96fbc0e1eeeb9df75eceda0fa91e85b459e62 
>   autotests/qml/filedialog_withparent.qml 5915ccf4b406e2406ccb1f0d024a8d9f16f8e221 
>   src/CMakeLists.txt 339192d11261b9a558895dd73955fecbeee2ca0b 
>   src/platformtheme/CMakeLists.txt 23f590ee48d3e395aecf347c5f92cd1bf4a48bbe 
>   src/platformtheme/config-platformtheme.h.cmake 89858d17de239cfc7eed1f40a8b828803de3299c 
>   src/platformtheme/frameworksintegration-5.16-font.sh 9a202a17815c60f9d413a48090cfa7a5532a5e1b 
>   src/platformtheme/frameworksintegration-5.16-font.upd ae7f797b9963f030dbf06909483969bb29718b7a 
>   src/platformtheme/kdeplatformfiledialogbase.cpp 856c052dffd2436399ed02dd9a8a4467c2fd18f2 
>   src/platformtheme/kdeplatformfiledialogbase_p.h 3191027bb1d10a70c2a01ef36007e0780ccb633a 
>   src/platformtheme/kdeplatformfiledialoghelper.h f80b8c78e455312acff23b0461a6f1131b360431 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 8b2ff6bc27048b41cd1c14a0c763179514ef0165 
>   src/platformtheme/kdeplatformsystemtrayicon.h 502942e7a0648312757fe2eb7d844f7bddbdd902 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp 6b882898bdc4ae9f9b16c535076d808c5a6c1440 
>   src/platformtheme/kdeplatformtheme.h 97d09df170ca6c489a5b2e1424eb8a9b98fc0ab8 
>   src/platformtheme/kdeplatformtheme.cpp 80dbcb7ed9651c4c730c17dc493d312e276ca3cb 
>   src/platformtheme/kdeplatformtheme.json 5d250ccf4d37fb8dba3be5d7cb7705f83700d5bc 
>   src/platformtheme/kdirselectdialog.cpp 0a65cd3e3a98bed7da7385d2500ab8d6d20bbed0 
>   src/platformtheme/kdirselectdialog_p.h 06be37f9311ee8275a08e742a6c882896920e8f0 
>   src/platformtheme/kfiletreeview.cpp 77b128d4c7d2309d871b3ab6289f3a8994284123 
>   src/platformtheme/kfiletreeview_p.h 844201814aa4f6e1d8c7131691eb770373ff56f5 
>   src/platformtheme/kfontsettingsdata.h 4b92c7df0d952be2989ed99b30109f64f51384d4 
>   src/platformtheme/kfontsettingsdata.cpp b0a4bbf9bc58c681496cffc6a6a8698efceafea7 
>   src/platformtheme/khintssettings.h ec064d32c8516e3647b7731e643bc90d03e7a833 
>   src/platformtheme/khintssettings.cpp 8adf6c52865beeebdf3ca328f3def121b487fc55 
>   src/platformtheme/main.cpp 05ed28723e6493cd374916a86e0708f26cf330bf 
>   tests/CMakeLists.txt 6bdd310322a39ad700f7ddfa0c065c0fe961b23e 
>   tests/qfiledialogtest.cpp 1d69ea15cb95fcc26b6e89db1f3323036b4a63e7 
> 
> Diff: https://git.reviewboard.kde.org/r/127756/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160504/a9adf098/attachment.html>