Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

David Edmundson david at davidedmundson.co.uk
Tue May 3 10:49:05 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127795/#review95130
-----------------------------------------------------------




src/plasma/dataengine.cpp 
<https://git.reviewboard.kde.org/r/127795/#comment64564>

    should this line still be here?


- David Edmundson


On May 3, 2016, 4:10 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127795/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 4:10 a.m.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   autotests/pluginloadertest.h 61fc963 
>   autotests/pluginloadertest.cpp 4f96780 
>   src/plasma/dataengine.cpp f942926 
> 
> Diff: https://git.reviewboard.kde.org/r/127795/diff/
> 
> 
> Testing
> -------
> 
> Test pass.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160503/41d30632/attachment.html>


More information about the Kde-frameworks-devel mailing list