Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127655/
-----------------------------------------------------------

(Updated May 3, 2016, 12:39 a.m.)


Review request for KDE Frameworks, Alex Richardson and Michael Pyne.


Changes
-------

Drop all-the-time-syncing idea and turn into fix for init +  some warnings


Summary (updated)
-----------------

Fix KAboutData::applicationData() to init from current Q*Application metadata


Repository: kcoreaddons


Description (updated)
-------

There is code in e.g. KXMLGUI which relies on KAboutData::applicationData(), without requiring the user to use KAboutData::setApplicationData(). So better be complete when initializing the data from the Q*Application metadata.

Also
- warn if there is no Q*App instance yet to set properties in KAboutData::setApplicationData
- check and warn if KAboutData::applicationData is out-of-sync with qapp data
- remove bogus check for empty display name, as the method defaults to componentname
- unit tests KAboutDataTest::testSetOfQApplicationData/testPickupOfQApplicationData


Diffs (updated)
-----

  autotests/kaboutdatatest.cpp f31e7f3 
  src/lib/kaboutdata.h 97c0f2b 
  src/lib/kaboutdata.cpp ceb0c06 

Diff: https://git.reviewboard.kde.org/r/127655/diff/


Testing
-------

Added autotests pass.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160503/d15d7204/attachment.html>