Review Request 127810: Fix some gcc5.3 compile warnings in kwayland

Sebastian Kügler sebas at kde.org
Mon May 2 13:21:29 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127810/#review95079
-----------------------------------------------------------


Ship it!




- Sebastian Kügler


On May 1, 2016, 8:32 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127810/
> -----------------------------------------------------------
> 
> (Updated May 1, 2016, 8:32 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Martin Gräßlin.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> eliminate -Wmissing-include-dirs, -Wunused-parameter and -Wsign-compare warnings from gcc5.3.1
> 
> 
> Diffs
> -----
> 
>   autotests/client/CMakeLists.txt ed0970b 
>   src/client/outputdevice.cpp 6fc3d3c 
>   src/client/outputmanagement.cpp 9aaf331 
>   src/client/plasmawindowmanagement.cpp 81c6a3b 
> 
> Diff: https://git.reviewboard.kde.org/r/127810/diff/
> 
> 
> Testing
> -------
> 
> still compiles.
> a warning remains that I don't know how to fix yet: /data/kde5/src/frameworks/kwayland/src/client/buffer_p.h:32:15: warning: ‘KWayland::Client::Buffer::Private’ has a field ‘KWayland::Client::Buffer::Private::nativeBuffer’ whose type uses the anonymous namespace
> 
> but otherwise most other compiler warnings are fixed with this patch
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160502/697525ce/attachment.html>


More information about the Kde-frameworks-devel mailing list