Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

Anthony Fieroni bvbfan at abv.bg
Sun May 1 05:54:17 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127795/
-----------------------------------------------------------

(Updated Май 1, 2016, 8:54 преди обяд)


Review request for KDE Frameworks and Marco Martin.


Changes
-------

DataEngine who is not refered is not valid and unused. nullEngine to test case.


Repository: plasma-framework


Description
-------

^^


Diffs (updated)
-----

  autotests/pluginloadertest.h 61fc963 
  autotests/pluginloadertest.cpp 4f96780 
  src/plasma/datacontainer.cpp ee067db 
  src/plasma/dataengine.cpp f942926 
  src/plasma/private/dataenginemanager.cpp 08e42fb 

Diff: https://git.reviewboard.kde.org/r/127795/diff/


Testing
-------

Test pass.


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160501/44a3079d/attachment.html>


More information about the Kde-frameworks-devel mailing list