Review Request 127501: Improve TCPSlaveBase::isConnected

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127501/
-----------------------------------------------------------

(Updated March 31, 2016, 8:01 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Repository: kio


Description
-------

Qt sockets returns ConnectedState even when error is set to RemoteHostClosedError after a write operation.

So make ::isConnected also check for RemoteHostClosedError.

This has the consequence that we have to create/delete the socket since Qt sockets have no way to reset their error state so if we want to reuse the slave to connect again it will never work with the same socket since it will always say RemoteHostClosedError.

I need this for https://git.reviewboard.kde.org/r/127502/


Diffs
-----

  src/core/tcpslavebase.cpp b9be69d 

Diff: https://git.reviewboard.kde.org/r/127501/diff/


Testing
-------

Seesms to work fine and the pop3 bugfix i have also works fine.


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160331/78e59af1/attachment.html>