Review Request 127536: KNewPasswordWidget: fix QPalette when the widget is disabled

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127536/#review94154
-----------------------------------------------------------




autotests/knewpasswordwidgettest.cpp (line 237)
<https://git.reviewboard.kde.org/r/127536/#comment64077>

    `QVERIFY(linePassword && linePassword->isEnabled());`
    
    ?



autotests/knewpasswordwidgettest.cpp (line 244)
<https://git.reviewboard.kde.org/r/127536/#comment64079>

    I'm not sure this is testing what you want to test...


- Aleix Pol Gonzalez


On March 31, 2016, 4:19 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127536/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 4:19 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck and David Faure.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> If the widget gets disabled, the verification's QLineEdit is disabled as well, but its QPalette is wrong (see the screenshots).
> This patch fixes the bug by setting the Active color group for the palette.
> 
> 
> Diffs
> -----
> 
>   autotests/knewpasswordwidgettest.h 3b7418700557cd3a2b3de91127f76a5bf99345d3 
>   autotests/knewpasswordwidgettest.cpp 4507dbdc899407afb72ffa14437f050aae0b57df 
>   src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd 
> 
> Diff: https://git.reviewboard.kde.org/r/127536/diff/
> 
> 
> Testing
> -------
> 
> A test case is added to reproduce the bug.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/d4d0d5be-91d4-4787-adc2-032d358a3dc5__knewpasswordwidget-disabled1.png
> After
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/46e24106-ceb5-486f-8222-d928c8690929__knewpasswordwidget-disabled2.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160331/7c623799/attachment.html>