Review Request 127522: kcodec: Simplify code (qCount -> std::count, homegrown isprint -> QChar::isPrint)

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127522/
-----------------------------------------------------------

(Updated March 29, 2016, 4:52 p.m.)


Review request for KDE Frameworks.


Changes
-------

Check QChar::isPrint() in if-condition


Repository: kcodecs


Description
-------

This patch does two things:
1. use std::count() instead of deprecated qCount()
2. use QChar::isPrint() instead of the homegrown isprint() function.

Especially (2) allows us to remove the header "src/probers/ctype_test_p.h", which looks like a C implementation of isprint().


Diffs (updated)
-----

  src/probers/UnicodeGroupProber.cpp cfbb06b 
  src/probers/ctype_test_p.h 0421f99 

Diff: https://git.reviewboard.kde.org/r/127522/diff/


Testing
-------

make test -> all tests PASS.


Thanks,

Dominik Haumann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160329/a286c007/attachment-0001.html>